javascript - Operators not working? -

-

ok did according suggestion looks amatuerish ha.. cos repeats same thing each percentage group: css , message. wondering if there way change it? if not, ok this..

if (69 < percentdiscount && percentdiscount < 101) {

        $(this).find("#percentoff").html('&gt; 70% off');         $(this).find("#percentoff").addclass('badge70');     }      else if (49 < percentdiscount && percentdiscount < 70) {          $(this).find("#percentoff").html('&gt; 50% off');         $(this).find("#percentoff").addclass('badge50');     }      else if (29 < percentdiscount && percentdiscount < 50) {          $(this).find("#percentoff").html('&gt; 30% off');         $(this).find("#percentoff").addclass('badge30');     }       else if (19 < percentdiscount && percentdiscount < 30) {          $(this).find("#percentoff").html('&gt; 20% off');         $(this).find("#percentoff").addclass('badge30');     }

you're checking percentdiscount that's both higher both numbers, in second if check, there no numbers left above 69. should instead (keeping exclusion logic):

if (percentdiscount > 69 && percentdiscount < 101) {         $(this).find("#percentoff").html('&gt; 70% off');     $(this).find("#percentoff").addclass('badge70'); }     else if (percentdiscount > 49 && percentdiscount < 69) {         $(this).find("#percentoff").html('&gt; 50% off');     $(this).find("#percentoff").addclass('badge50'); }     else if (percentdiscount > 29 && percentdiscount < 49) {         $(this).find("#percentoff").html('&gt; 30% off');     $(this).find("#percentoff").addclass('badge30'); }

swap terms they're in same order have above, think you'll find it's much easier read. however, overall terms exclude 69, , 49 points specifically, i'd change logic this:

if (percentdiscount > 69) {         $(this).find("#percentoff").html('&gt; 70% off');     $(this).find("#percentoff").addclass('badge70'); }     else if (percentdiscount > 49) {         $(this).find("#percentoff").html('&gt; 50% off');     $(this).find("#percentoff").addclass('badge50'); }     else if (percentdiscount > 29) {         $(this).find("#percentoff").html('&gt; 30% off');     $(this).find("#percentoff").addclass('badge30'); }

the first if grabs above 69, next above, 49, etc...much simpler :)


Comments

Post a Comment

Popular posts from this blog

android - Spacing between the stars of a rating bar? -

-
ho can set spacing beween stars? thats ratingbar: ratingbar = (ratingbar) inflater.inflate(r.layout.ratingbar, null); ratingbar.setlayoutparams(new layoutparams(layoutparams.wrap_content, layoutparams.wrap_content)); the layout: <?xml version="1.0" encoding="utf-8"?> <ratingbar xmlns:android="http://schemas.android.com/apk/res/android" style="@style/mystyle" android:layout_alignparentright="true" android:layout_height="19dp" android:layout_width="wrap_content" android:numstars="5"> </ratingbar> the style: <style name="mystyle" parent="@android:style/widget.ratingbar"> <item name="android:progressdrawable">@drawable/android_r2_ratingstar_yellow</item> <item name="android:indeterminatedrawable">@drawable/android_r2_ratingstar_grey</item> </style> thanks, cheers you have
Read more

aspxgridview - Devexpress grid - header filter does not work if column is initially hidden -

-
i'm using devexpress grid , i'm trying 'country' column display header filter properly: <dx:gridviewdatacolumn caption="country" fieldname="countryname" showincustomizationform="true" visible="false"> <settings allowheaderfilter="true"/> </dx:gridviewdatacolumn> if 'country' column set visible='true', header filter displayed should(it shows value option list). however, want 'country' column hidden, available in customization window(like in code above). in case, when column dragged outside customization window , grid , header filter clicked, javascript error encountered: element null element.addeventlistener(eventname, func, true); is known bug? there workarounds? set aspxgridview.settings.showheaderfilterbutton property true resolve problem. the following markup works fine me (i using dxperience 10.1.7): <asp:accessdatasource id="accessda
Read more

c# - How to execute a particular part of code asynchronously in a class -

-
i creating speech recognition engine that's going respond user commands.i have created button enable , disable speech recognition per user convenience.i have used dispose() of speech engine disable speech recoginition.here code private void button1_click(object sender, routedeventargs e) { engineon = !engineon; if (engineon) { speechengine = speech.createspeechengine(); //speech class creates , returns new speech engine. speechengine.audiolevelupdated += new eventhandler<audiolevelupdatedeventargs>(speechengine_audiolevelupdated); // use system's default microphone speechengine.setinputtodefaultaudiodevice(); speechengine.loadgrammar(new dictationgrammar()); // start listening speechengine.recognizeasync(recognizemode.multiple); } else { speechclass.myengine.dispose(); } } but disposal of speech obj
Read more