javascript - Operators not working? -

-

ok did according suggestion looks amatuerish ha.. cos repeats same thing each percentage group: css , message. wondering if there way change it? if not, ok this..

if (69 < percentdiscount && percentdiscount < 101) {

        $(this).find("#percentoff").html('&gt; 70% off');         $(this).find("#percentoff").addclass('badge70');     }      else if (49 < percentdiscount && percentdiscount < 70) {          $(this).find("#percentoff").html('&gt; 50% off');         $(this).find("#percentoff").addclass('badge50');     }      else if (29 < percentdiscount && percentdiscount < 50) {          $(this).find("#percentoff").html('&gt; 30% off');         $(this).find("#percentoff").addclass('badge30');     }       else if (19 < percentdiscount && percentdiscount < 30) {          $(this).find("#percentoff").html('&gt; 20% off');         $(this).find("#percentoff").addclass('badge30');     }

you're checking percentdiscount that's both higher both numbers, in second if check, there no numbers left above 69. should instead (keeping exclusion logic):

if (percentdiscount > 69 && percentdiscount < 101) {         $(this).find("#percentoff").html('&gt; 70% off');     $(this).find("#percentoff").addclass('badge70'); }     else if (percentdiscount > 49 && percentdiscount < 69) {         $(this).find("#percentoff").html('&gt; 50% off');     $(this).find("#percentoff").addclass('badge50'); }     else if (percentdiscount > 29 && percentdiscount < 49) {         $(this).find("#percentoff").html('&gt; 30% off');     $(this).find("#percentoff").addclass('badge30'); }

swap terms they're in same order have above, think you'll find it's much easier read. however, overall terms exclude 69, , 49 points specifically, i'd change logic this:

if (percentdiscount > 69) {         $(this).find("#percentoff").html('&gt; 70% off');     $(this).find("#percentoff").addclass('badge70'); }     else if (percentdiscount > 49) {         $(this).find("#percentoff").html('&gt; 50% off');     $(this).find("#percentoff").addclass('badge50'); }     else if (percentdiscount > 29) {         $(this).find("#percentoff").html('&gt; 30% off');     $(this).find("#percentoff").addclass('badge30'); }

the first if grabs above 69, next above, 49, etc...much simpler :)


Comments

Post a Comment

Popular posts from this blog

c++ - How to modify context menu of internet explorer using IDocHostUIHandler::ShowContextMenu? -

-
i trying implement custom menu internet explorer 7.0. have use idochostuihandler::showcontextmenu only. till able implement basic context menu 2 options. problem disabled default. sample code same is: hresult cwebeventhandler::showcontextmenu(dword dwid,point *ppt, iunknown *pcmdtarget, idispatch *pdispobject) { if (false) // put guard code here. of not consider return s_false; // show standard context menus. else { iolewindow* pwnd = null; hresult hr = pcmdtarget->queryinterface(iid_iolewindow, (void**) &pwnd); if (succeeded(hr)) { hwnd hwnd; if (succeeded(pwnd->getwindow(&hwnd))) { hmenu menu = ::createpopupmenu(); ::appendmenu(menu, mf_string, id_hello, l"&hello" ); // id_hello & id_world 2 menu resource items ::appendmenu(menu, mf_string, id_world, l"&world" ); ...
Read more

c# - Getting "Internal .Net Framework Data Provider error 30" error when column has NULL value -

-
i have simple .net console program uses odbcdatareader fetch rows advantage local server. using system dsn defined via odbc administrator on windows 7. data source uses advantage streamlinesql odbc driver v 10.00.00.03 , following params: database path: table type: advantage available server types: local server (als) the program works fine until encounters row has null value in column. exception: system.invalidoperationexception caught message=internal .net framework data provider error 30. source=system.data stacktrace: @ system.data.providerbase.dbbuffer.validate(int32 offset, int32 count) @ system.data.providerbase.dbbuffer.ptrtostringuni(int32 offset, int32 length) @ system.data.odbc.odbcdatareader.internalgetstring(int32 i) @ system.data.odbc.odbcdatareader.getvalue(int32 i, typemap typemap) @ system.data.odbc.odbcdatareader.getvalue(int32 i) @ system.data.odbc.odbcdatareader.isdbnull(int32 i) @ odbctest.program....
Read more

android - Spacing between the stars of a rating bar? -

-
ho can set spacing beween stars? thats ratingbar: ratingbar = (ratingbar) inflater.inflate(r.layout.ratingbar, null); ratingbar.setlayoutparams(new layoutparams(layoutparams.wrap_content, layoutparams.wrap_content)); the layout: <?xml version="1.0" encoding="utf-8"?> <ratingbar xmlns:android="http://schemas.android.com/apk/res/android" style="@style/mystyle" android:layout_alignparentright="true" android:layout_height="19dp" android:layout_width="wrap_content" android:numstars="5"> </ratingbar> the style: <style name="mystyle" parent="@android:style/widget.ratingbar"> <item name="android:progressdrawable">@drawable/android_r2_ratingstar_yellow</item> <item name="android:indeterminatedrawable">@drawable/android_r2_ratingstar_grey</item> </style> thanks, cheers you have ...
Read more