javascript - Scripting error in jQuery/AJAX code snippet? -

-

this should simple question, answer has eluded me time now. seem have error in code, either scripting typo, or error in logic. kindly clarify problem?

here's code:

function getquestion() {         $.ajax({             type: "get",             url: "questions.xml",             datatype: "xml",             success: function(xml) {                 x = 0;                 x = $(xml).find('question').length;                  var questionid = $.random(x);                  $(xml).find('question').each(function(){                     if(this.id == questionid) {                         var text = $(this).find('body').text();                         $('#questionbody')[0].innerhtml = text;                     }                 }); //close each             } //close success         });//close ajax     }; //close function getquestion

it's meant read in xml file, search specific item random id, , plug contents of body <p> have in html file. however, isn't working expected. have made error?

thanks, elliot bonneville

this general observation , not answer, may in future:

//notice function easier consume in 1 glance function getquestion() {      $.ajax({         type: "get",         url: "questions.xml",         datatype: "xml",         success: getquestionsuccess     });//close ajax  }; //close function getquestion  // <-superfluous semicolon?    //notice function easier consume in 1 glance function getquestionsuccess(xml) {      //let's quit querying each time need them     var questions = $(xml).find('question');  //bonus, it's jquery object!      //x = 0; // <-unnecessary assignment. gets obliterated on next line.     x = questions.length; //the count of "question"s found      var questionid = $.random(x);      //but wait, read next comments below     questions.each(function(){         if(this.id == questionid) {             var text = $(this).find('body').text();             $('#questionbody')[0].innerhtml = text;         }     }); //close each      //since seem looking index questionid of questions,      //why not jump 1 instead of looping?     //also, if have 1 "#questionbody" in document can more "jquery"ish.     $('#questionbody')[0].innerhtml = questions[questionid].find('body').text();      //only one:     $('#questionbody').html( questions[questionid].find('body').text() );  } //close success

so clarify :\

//i shredded down reasonable number of lines. shorter still, albeit less readable. //but think pretty readable. function getquestionsuccess(xml) {      var questions = $(xml).find('question');      var questionid = $.random(questions.length);      $('#questionbody').html( questions[questionid].find('body').text() );  } //close success

Comments

Post a Comment

Popular posts from this blog

android - Spacing between the stars of a rating bar? -

-
ho can set spacing beween stars? thats ratingbar: ratingbar = (ratingbar) inflater.inflate(r.layout.ratingbar, null); ratingbar.setlayoutparams(new layoutparams(layoutparams.wrap_content, layoutparams.wrap_content)); the layout: <?xml version="1.0" encoding="utf-8"?> <ratingbar xmlns:android="http://schemas.android.com/apk/res/android" style="@style/mystyle" android:layout_alignparentright="true" android:layout_height="19dp" android:layout_width="wrap_content" android:numstars="5"> </ratingbar> the style: <style name="mystyle" parent="@android:style/widget.ratingbar"> <item name="android:progressdrawable">@drawable/android_r2_ratingstar_yellow</item> <item name="android:indeterminatedrawable">@drawable/android_r2_ratingstar_grey</item> </style> thanks, cheers you have ...
Read more

html - Instapaper-like algorithm -

-
does of algorithm extracts contents webpage? instapaper ? there 2 steps instapaper does: find main content block on page (excluding headers, footers, menus etc) from content block extract , format text to find content block (typically html block element, div containing key page text content) instapaper uses algorithm 1 used readability . can @ source of readability.js see what's going on, @ core tries find area on page highest text/link ratio, although has other simple scoring metrics (e.g. off top of head, things ratio of text commas, para elements etc) go heuristics. once have identified root node element, relevant content, you'll need format it, if want can pull node element containing text out of source document , insert yours, in reality you'll want remove existing styles , apply own, standard , feel. if want output nice text-only can use jericho's renderer . update1 : should mention else instapaper - follow 'pagination' links (...
Read more

c# - How to execute a particular part of code asynchronously in a class -

-
i creating speech recognition engine that's going respond user commands.i have created button enable , disable speech recognition per user convenience.i have used dispose() of speech engine disable speech recoginition.here code private void button1_click(object sender, routedeventargs e) { engineon = !engineon; if (engineon) { speechengine = speech.createspeechengine(); //speech class creates , returns new speech engine. speechengine.audiolevelupdated += new eventhandler<audiolevelupdatedeventargs>(speechengine_audiolevelupdated); // use system's default microphone speechengine.setinputtodefaultaudiodevice(); speechengine.loadgrammar(new dictationgrammar()); // start listening speechengine.recognizeasync(recognizemode.multiple); } else { speechclass.myengine.dispose(); } } but disposal of speech obj...
Read more