Memory leak problems while splitting a string in C -

-

im trying split string according following rules:

  1. words without "" around them should treated seperate strings
  2. anything wiht "" around should treated 1 string

however when run in valgrind invalid frees , invalid read size errors, if remove 2 frees memory leak. if point me in right direction appreciate it

the code calls split_string

    char *param[5];     for(i = 0;i < 5;i++) {             param[i] = null;     }     char* user = getenv("logname");     char tid[9];     char* instring = (char*) malloc(201);      /     while((printf("%s %s >",user,gettime(tid)))&&(instring             =fgets(instring,201,stdin)) != null) {             int paramsize = split_string(param, instring);

the code tries free param

                for(i = 0;i < 5;i++) {                 if(param[i] != null) {                     free(param[i]);                     fprintf(stderr,"%d",i);                 }             } 
    int split_string(char** param, char* string) {     int paramplace = 0; //hvor vi er param     int tempplace = 0; //hvor temp vi er      char* temp = malloc(201);      int command = 0;      int message = 0;      for(; (*string != '\0') && (*string != 10) && paramplace < 4; string++) {             if((*string == ' ') && (message == 0)) {                     if(command == 1) {                         temp[tempplace] = '\0';                          param[paramplace++] = temp;                          tempplace = 0;                         command = 0;                     }             }             else {                     if(*string =='"') {                             if(message == 0) message = 1;                             else message = 0;                     }                     if(command == 0) {                             free(temp);                             temp = malloc(201);                     }                     command = 1;                     if(*string != '"') {                             temp[tempplace++] = *string;                     }             }     }     if(command == 1) {             temp[tempplace] = '\0';             param[paramplace++] = temp;     }     param[paramplace] = null;     free(temp);     return paramplace; }

as far can see, want put split strings param array of pointers (presumably making caller responsible freeing them). in first branch of if statement in loop, assigning current temp buffer place. however, once start new string (when comnmand == 0, free space, rendering previous param entry pointer invalid.

only free each pointer once. wouldn't rule out other leaks in code: think can simplify state machine (and find other bugs result).


Comments

Post a Comment

Popular posts from this blog

android - Spacing between the stars of a rating bar? -

-
ho can set spacing beween stars? thats ratingbar: ratingbar = (ratingbar) inflater.inflate(r.layout.ratingbar, null); ratingbar.setlayoutparams(new layoutparams(layoutparams.wrap_content, layoutparams.wrap_content)); the layout: <?xml version="1.0" encoding="utf-8"?> <ratingbar xmlns:android="http://schemas.android.com/apk/res/android" style="@style/mystyle" android:layout_alignparentright="true" android:layout_height="19dp" android:layout_width="wrap_content" android:numstars="5"> </ratingbar> the style: <style name="mystyle" parent="@android:style/widget.ratingbar"> <item name="android:progressdrawable">@drawable/android_r2_ratingstar_yellow</item> <item name="android:indeterminatedrawable">@drawable/android_r2_ratingstar_grey</item> </style> thanks, cheers you have ...
Read more

html - Instapaper-like algorithm -

-
does of algorithm extracts contents webpage? instapaper ? there 2 steps instapaper does: find main content block on page (excluding headers, footers, menus etc) from content block extract , format text to find content block (typically html block element, div containing key page text content) instapaper uses algorithm 1 used readability . can @ source of readability.js see what's going on, @ core tries find area on page highest text/link ratio, although has other simple scoring metrics (e.g. off top of head, things ratio of text commas, para elements etc) go heuristics. once have identified root node element, relevant content, you'll need format it, if want can pull node element containing text out of source document , insert yours, in reality you'll want remove existing styles , apply own, standard , feel. if want output nice text-only can use jericho's renderer . update1 : should mention else instapaper - follow 'pagination' links (...
Read more

c# - How to execute a particular part of code asynchronously in a class -

-
i creating speech recognition engine that's going respond user commands.i have created button enable , disable speech recognition per user convenience.i have used dispose() of speech engine disable speech recoginition.here code private void button1_click(object sender, routedeventargs e) { engineon = !engineon; if (engineon) { speechengine = speech.createspeechengine(); //speech class creates , returns new speech engine. speechengine.audiolevelupdated += new eventhandler<audiolevelupdatedeventargs>(speechengine_audiolevelupdated); // use system's default microphone speechengine.setinputtodefaultaudiodevice(); speechengine.loadgrammar(new dictationgrammar()); // start listening speechengine.recognizeasync(recognizemode.multiple); } else { speechclass.myengine.dispose(); } } but disposal of speech obj...
Read more